Skip to content
This repository has been archived by the owner on Dec 15, 2021. It is now read-only.

Add Status to kubeless CRD objects #482

Open
murali-reddy opened this issue Dec 8, 2017 · 5 comments
Open

Add Status to kubeless CRD objects #482

murali-reddy opened this issue Dec 8, 2017 · 5 comments

Comments

@murali-reddy
Copy link
Contributor

murali-reddy commented Dec 8, 2017

We should add resource status to the function object, and any other CRD's kubeless may have (e.g. runtime, trigger etc)

to start with function object should have Status along with Spec something like below:

// Function object
type Function struct {
	metav1.TypeMeta `json:",inline"`
	Metadata               metav1.ObjectMeta `json:"metadata"`
	Spec   FunctionSpec `json:"spec"`
        Status FunctionStatus `json:"status,omitempty"`
}

Things like function status, http endpoint etc should go in the FunctionStatus.

Current way of inferring the status of the function by kubeless client should go away into controller. Client should just reflect the status of the function returned by API.

@andresmgot
Copy link
Contributor

does this require a watcher in the controller?

@murali-reddy
Copy link
Contributor Author

murali-reddy commented Dec 11, 2017

Kubeless controller is/will be the source of change to function objects (or any other CRD api objects that may come), so dont see need for it.

@andresmgot
Copy link
Contributor

what if the deployment crashes? or should the controller wait until the deployment is ready?

murali-reddy added a commit to murali-reddy/kubeless that referenced this issue Dec 13, 2017
kubeless client code. We can not assume client has RBAC to access
deployments.

Fixes vmware-archive#482
murali-reddy added a commit to murali-reddy/kubeless that referenced this issue Dec 13, 2017
kubeless client code. We can not assume client has RBAC to access
deployments.

Fixes vmware-archive#482
murali-reddy added a commit to murali-reddy/kubeless that referenced this issue Dec 13, 2017
kubeless client code. We can not assume client has RBAC to access
deployments.

Fixes vmware-archive#482
murali-reddy added a commit to murali-reddy/kubeless that referenced this issue Dec 13, 2017
kubeless client code. We can not assume client has RBAC to access
deployments.

Fixes vmware-archive#482
murali-reddy added a commit to murali-reddy/kubeless that referenced this issue Dec 14, 2017
kubeless client code. We can not assume client has RBAC to access
deployments.

Fixes vmware-archive#482
@sayanh
Copy link
Contributor

sayanh commented Jun 19, 2018

@andresmgot @murali-reddy Do we still consider solving this? As of now, I do see status: {} subresource but there is no feedback from kubeless-controller.

@murali-reddy
Copy link
Contributor Author

Support for Status in CRD only got in 1.10 and will be beta in 1.11

kubernetes/enhancements#571

When Kubeless moves to latest client-go and supports 1.10/1.11 we can add support for status.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants