Move declarations of anchors to get tests to pass

[Ben16]

Thanks for submitting an pull request to pcf-pipelines.

To speed up the process of reviewing your pull request please provide us with:

• A short explanation of the proposed change:
  Moving declarations of anchors in ci/pcf-pipelines/pipeline.yml and upgrade-buildpacks/pipeline.yml to the top of each file.

• An explanation of the use cases your change solves:
  Tests will fail when run locally because they reference anchors that have not been declared yet.

• Expected result after the change:
  All tests pass.

• Current result before the change:
  When running ginkgo -r -p in pcf-pipelines:

• Failure [0.003 seconds]
pcf-pipelines
.../pcf-pipelines/pcf_pipelines_test.go:21
  pipeline at ci/pcf-pipelines/pipeline.yml
 .../pcf-pipelines/pcf_pipelines_test.go:53
    specifies only valid job names in any `passed` definitions in the buildplan [It]
    .../pcf-pipelines/pcf_pipelines_test.go:62

    Expected error:
        <*errors.errorString | 0xc0004523c0>: {
            s: "yaml: unknown anchor 'norm-ci-locks-params' referenced",
        }
        yaml: unknown anchor 'norm-ci-locks-params' referenced
    not to have occurred

    .../pcf-pipelines/pcf_pipelines_test.go:66

<several other similar errors for unknown anchors of other names>

• Links to any other associated PRs or issues:

• I have viewed signed and have submitted the Contributor License Agreement

• I have made this pull request to the master branch

• I have run all the unit tests

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

[pivotal-issuemaster]

@Ben16 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

[pivotal-issuemaster]

@Ben16 Thank you for signing the Contributor License Agreement!

[kcboyle]

Hi @Ben16 ! When we run the tests locally and in our CI we do not have any failures. Did you make sure that you used glide install to get the proper versions of the dependencies before running?

Also, were you wanting to run the tests locally to do another PR, or are you trying to use this as a main source of pipeline? If you are using it to alter and change your pipeline, we recommend using the pivnet release over the github release every time.