Skip to content
This repository has been archived by the owner on Feb 11, 2020. It is now read-only.

don't be so greedy #388

Closed

Conversation

pivotal-ben-chacko
Copy link
Contributor

Thanks for submitting an pull request to pcf-pipelines.

To speed up the process of reviewing your pull request please provide us with:

  • Recently there has been some format changes in the pivnet yaml file for GCP where the opsman tarball is located under the US directory for all regions example:

OpsMan 2.4

$> cat OpsManager2.4-build.192onGCP.yml

us: ops-manager-us/pcf-gcp-2.4-build.192.tar.gz
eu: ops-manager-us/pcf-gcp-2.4-build.192.tar.gz
asia: ops-manager-us/pcf-gcp-2.4-build.192.tar.gz

This results in grep matching more then one occurrence of the pattern. This leads to the following incorrect new yml file from being created.

disk_image_url: ops-manager-us/pcf-gcp-2.3-build.305.tar.gz
ops-manager-us/pcf-gcp-2.3-build.305.tar.gz
ops-manager-us/pcf-gcp-2.3-build.305.tar.gz

Notice the 2 additional values being inserted in the key value pair.

The proposed pull request would limit the regex matching to one occurrence, when grep is run.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

@pivotal-issuemaster
Copy link

@pivotal-ben-chacko Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

1 similar comment
@pivotal-issuemaster
Copy link

@pivotal-ben-chacko Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@pivotal-ben-chacko Thank you for signing the Contributor License Agreement!

@kcboyle
Copy link
Contributor

kcboyle commented May 24, 2019

merged via command line.

This is being merged in because this is a breaking change for current pipelines.

This will be included in the next (last) release of pcf-pipelines. This feature has not been tested by CI, nor will it be. Use this commit and the corresponding release at your own risk.

In the future, please use platform-automation for all your automation needs. Pivotal Documentation

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants