This repository has been archived by the owner on Feb 11, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting an pull request to pcf-pipelines.
To speed up the process of reviewing your pull request please provide us with:
OpsMan 2.4
$> cat OpsManager2.4-build.192onGCP.yml
us: ops-manager-us/pcf-gcp-2.4-build.192.tar.gz
eu: ops-manager-us/pcf-gcp-2.4-build.192.tar.gz
asia: ops-manager-us/pcf-gcp-2.4-build.192.tar.gz
This results in grep matching more then one occurrence of the pattern. This leads to the following incorrect new yml file from being created.
disk_image_url: ops-manager-us/pcf-gcp-2.3-build.305.tar.gz
ops-manager-us/pcf-gcp-2.3-build.305.tar.gz
ops-manager-us/pcf-gcp-2.3-build.305.tar.gz
Notice the 2 additional values being inserted in the key value pair.
The proposed pull request would limit the regex matching to one occurrence, when grep is run.