Skip to content

Commit

Permalink
Log error; do not bail early
Browse files Browse the repository at this point in the history
Fixes #455

But adds technical debt addressed by SEP defined in #464

Signed-off-by: Chuck Ha <[email protected]>
  • Loading branch information
Chuck Ha committed Jul 5, 2018
1 parent 4f61a01 commit 6a51d1d
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion pkg/discovery/queries.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import (
"time"

"github.com/heptio/sonobuoy/pkg/config"
"github.com/heptio/sonobuoy/pkg/errlog"
"github.com/pkg/errors"
"github.com/sirupsen/logrus"
apiextensionsclient "k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset"
Expand Down Expand Up @@ -317,7 +318,8 @@ func QueryNSResources(kubeClient kubernetes.Interface, recorder *QueryRecorder,
start := time.Now()
err := gatherPodLogs(kubeClient, ns, opts, cfg)
if err != nil {
return err
errlog.LogError(err)
continue
}
duration := time.Since(start)
recorder.RecordQuery("PodLogs", ns, duration, err)
Expand Down

0 comments on commit 6a51d1d

Please sign in to comment.