Only apply imagePullPolicy to plugins if instructed #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not a big change but just lots of golden files being tweaked. Added a field to the config object and plumbed it through to a flag. Gated logic on that value. |
johnSchnake
commented
May 12, 2022
| @@ -460,7 +463,7 @@ func TestGenerateManifestGolden(t *testing.T) { | |||
| }, | |||
| }, | |||
| }, | |||
| goldenFile: filepath.Join("testdata", "imagePullPolicy-all-plugins.golden"), | |||
| goldenFile: filepath.Join("testdata", "imagePullPolicy-not-all-plugins.golden"), | |||
There was a problem hiding this comment.
This was actually a previously duplicated test oddly. Now one is for forcing the values, and the other isnt.
johnSchnake
commented
May 12, 2022
| - name: SONOBUOY_RESULTS_DIR | ||
| value: /tmp/sonobuoy/results | ||
| image: hello:v9 | ||
| imagePullPolicy: Always |
There was a problem hiding this comment.
Not forced and has its value, not the default (IfNotPresent)
Adds a new option which allows the user to specify whether or not to apply the imagePullPolicy to all plugins and override their stated values. This is important since even the default value was overwriting explicit values in the plugins leading to confusing behavior. Techinically a breaking change for someone who was running sonobuoy CLI with the --image-pull-policy flag to overwrite explicit values. They will now need to add the --force-image-pull-policy flag to obtain the same behavior. This makes all modifications to plugins explicit via some option rather than this one being implicit. Fixes #1652 Signed-off-by: John Schnake <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new option which allows the user to specify whether or
not to apply the imagePullPolicy to all plugins and override
their stated values.
This is important since even the default value was overwriting
explicit values in the plugins leading to confusing behavior.
Techinically a breaking change for someone who was running
sonobuoy CLI with the --image-pull-policy flag to overwrite explicit
values. They will now need to add the --force-image-pull-policy flag
to obtain the same behavior. This makes all modifications to plugins
explicit via some option rather than this one being implicit.
Fixes #1652
Signed-off-by: John Schnake [email protected]
Release note: