Skip requirement of kubeconfig for e2e & gen #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier `kubeconfig` was needed to use the sub-commands `e2e` and `gen` which is unnecessary since using these sub-commands does not require communication to Kubernetes server. This commit removes that necessity. Signed-off-by: Suraj Deshmukh <[email protected]>
chuckha
suggested changes
Jun 6, 2018
| @@ -75,12 +75,10 @@ func e2es(cmd *cobra.Command, args []string) { | |||
| os.Exit(1) | |||
| } | |||
| defer gzr.Close() | |||
| restConfig, err := e2eflags.kubecfg.Get() | |||
There was a problem hiding this comment.
This might be a slightly deeper change than I originally expected. Since e2e does many things (oops) it will need the config later on. Would you be able to move this down below if !e2eflags.rerun { this line?
There is a flag, which needs rethinking, --rerun which allows users to rerun the failed tests if an error is detected.
There was a problem hiding this comment.
done, rather than moving it down I have added a check.
Moving down was causing the initiation of client twice, so added a check rather.
The special case/flag of `e2e` `--rerun-failed` needs kubeconfig, this commit adds a check to see if this is enabled then it creates the sonobuoy client with config, otherwise without it. Signed-off-by: Suraj Deshmukh <[email protected]>
jhamilton1
pushed a commit
to jhamilton1/sonobuoy
that referenced
this pull request
Jun 27, 2018
* Skip requirement of kubeconfig for e2e & gen Earlier `kubeconfig` was needed to use the sub-commands `e2e` and `gen` which is unnecessary since using these sub-commands does not require communication to Kubernetes server. This commit removes that necessity. Signed-off-by: Suraj Deshmukh <[email protected]> * With `e2e` subcommand, kubeconfig needed The special case/flag of `e2e` `--rerun-failed` needs kubeconfig, this commit adds a check to see if this is enabled then it creates the sonobuoy client with config, otherwise without it. Signed-off-by: Suraj Deshmukh <[email protected]> Signed-off-by: Jesse Hamilton [email protected]
jhamilton1
pushed a commit
to jhamilton1/sonobuoy
that referenced
this pull request
Jun 27, 2018
* Skip requirement of kubeconfig for e2e & gen Earlier `kubeconfig` was needed to use the sub-commands `e2e` and `gen` which is unnecessary since using these sub-commands does not require communication to Kubernetes server. This commit removes that necessity. Signed-off-by: Suraj Deshmukh <[email protected]> * With `e2e` subcommand, kubeconfig needed The special case/flag of `e2e` `--rerun-failed` needs kubeconfig, this commit adds a check to see if this is enabled then it creates the sonobuoy client with config, otherwise without it. Signed-off-by: Suraj Deshmukh <[email protected]> Signed-off-by: Jesse Hamilton [email protected] Signed-off-by: Jesse Hamilton [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Earlier
kubeconfigwas needed to use the sub-commandse2eandgenwhich is unnecessary since using these sub-commands does not require
communication to Kubernetes server.
This commit removes that necessity.
Which issue(s) this PR fixes
Signed-off-by: Suraj Deshmukh [email protected]