Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default version for results reader #477

Merged
merged 1 commit into from
Jul 11, 2018

Conversation

chuckha
Copy link
Contributor

@chuckha chuckha commented Jul 11, 2018

Fixes #476

Signed-off-by: Chuck Ha [email protected]

What this PR does / why we need it:
This PR adds a default so our results reader is making a guess instead of erroring.

Improved robustness for results reader

Copy link
Contributor

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@timothysc timothysc merged commit 52484b0 into vmware-tanzu:master Jul 11, 2018
@chuckha chuckha deleted the results-update branch July 11, 2018 17:00
@timh timh unassigned liztio Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Results reader fails on newer versions. Needs default.
3 participants