Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set GitSHA when using goreleaser #750

Merged
merged 1 commit into from
Jun 16, 2019
Merged

Set GitSHA when using goreleaser #750

merged 1 commit into from
Jun 16, 2019

Conversation

johnSchnake
Copy link
Contributor

What this PR does / why we need it:
The makefile sets this flag but goreleaser was not configured
to do so.

Which issue(s) this PR fixes
Fixes #748

Special notes for your reviewer:
If you download/install https://github.com/goreleaser/goreleaser you can run the following goreleaser command to test it out (for darwin; you can specify the linux path if you need that version):

goreleaser --skip-publish --skip-validate --rm-dist && ./dist/darwin_amd64/sonobuoy version

Release note:

Fixed a bug which caused releases to not list the GitSHA they were built from.

The makefile sets this flag but goreleaser was not configured
to do so.

Fixes #748

Signed-off-by: John Schnake <[email protected]>
@johnSchnake johnSchnake requested a review from zubron June 15, 2019 00:32
@codecov-io
Copy link

Codecov Report

Merging #750 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #750   +/-   ##
=======================================
  Coverage   42.59%   42.59%           
=======================================
  Files          70       70           
  Lines        4029     4029           
=======================================
  Hits         1716     1716           
  Misses       2208     2208           
  Partials      105      105

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d02613...c0694a8. Read the comment docs.

@johnSchnake johnSchnake merged commit 7d7bd81 into vmware-tanzu:master Jun 16, 2019
@johnSchnake johnSchnake deleted the goreleaserFullCommit branch June 16, 2019 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitSHA isn't being set properly in build
3 participants