Write plugin definitions in their respective folders #812
Conversation
Codecov Report
@@ Coverage Diff @@
## master #812 +/- ##
==========================================
- Coverage 43.42% 43.35% -0.08%
==========================================
Files 71 71
Lines 4260 4274 +14
==========================================
+ Hits 1850 1853 +3
- Misses 2301 2314 +13
+ Partials 109 107 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Thanks, @johnSchnake! I just have one question about the file permissions but otherwise it's good 👍
pkg/discovery/discovery.go
Outdated
| err = ioutil.WriteFile( | ||
| filepath.Join(outputDir, results.PluginsDir, p.GetName(), pluginDefinitionFilename), | ||
| b, | ||
| os.FileMode(0666), |
There was a problem hiding this comment.
Minor point, but would 644 be enough for the permissions here? That's the permissions that other files in the resulting tarball use.
There was a problem hiding this comment.
👍 Thanks for pointing that out; I just chose a random value and thought I'd come back to it and forgot. That would be fine for me.
The plugin info used to be written in the config but that was removed and also didn't have any of the information like sessionID, fields that could be altered by the config, etc. This change dumps the loaded configuration data into the folder at which users will most likely look for it. In order to avoid an import cycle, it also removes a type that was not used anywhere. Separated this small bit of logic from my larger PR on making plugin results more clearly reported. Related to #306 Signed-off-by: John Schnake <[email protected]>
What this PR does / why we need it:
The plugin info used to be written in the config but that was
removed and also didn't have any of the information like sessionID,
fields that could be altered by the config, etc.
This change dumps the loaded configuration data into the folder
at which users will most likely look for it.
In order to avoid an import cycle, it also removes a type that was
not used anywhere.
Separated this small bit of logic from my larger PR on making
plugin results more clearly reported.
Which issue(s) this PR fixes
Related to #306
Special notes for your reviewer:
Release note: