Use gcloud auth instead of docker-credential-gcr #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used docker-credential-gcr only once we moved to Jenkins and it was available on the agents already. This change moves back to using gcloud auth like it was when we originally published images via Travis. Signed-off-by: John Schnake <[email protected]>
zubron
approved these changes
Aug 14, 2019
|
xref c27ab1a |
Codecov Report
@@ Coverage Diff @@
## master #836 +/- ##
=========================================
- Coverage 47.01% 46.9% -0.11%
=========================================
Files 75 75
Lines 4667 4667
=========================================
- Hits 2194 2189 -5
- Misses 2345 2348 +3
- Partials 128 130 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We used docker-credential-gcr only once we moved to Jenkins and
it was available on the agents already. This change moves back
to using gcloud auth like it was when we originally published
images via Travis.
Which issue(s) this PR fixes
Related to #808
Special notes for your reviewer:
Unable to test this on non-master branches since creds are protected. Will have to merge and iterate.
Release note: