Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kind and dep to PATH in Travis #902

Merged
merged 1 commit into from
Sep 25, 2019

Conversation

zubron
Copy link
Contributor

@zubron zubron commented Sep 24, 2019

Instead of placing kind and dep in the working directory for
the Travis CI build, place them in a location which is in the
PATH so they can be easily used elsewhere.
It also allows us to fix the deploy_kind target in our Makefile
which assumed that kind was in the current directory.

@codecov-io
Copy link

codecov-io commented Sep 24, 2019

Codecov Report

Merging #902 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #902   +/-   ##
=======================================
  Coverage   46.72%   46.72%           
=======================================
  Files          76       76           
  Lines        5096     5096           
=======================================
  Hits         2381     2381           
  Misses       2577     2577           
  Partials      138      138

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7473b3d...5f16d0b. Read the comment docs.

@zubron zubron force-pushed the add-kind-to-path-in-travis branch from 60b68fe to f987e2e Compare September 24, 2019 21:14
@zubron zubron force-pushed the add-kind-to-path-in-travis branch from f987e2e to 5f16d0b Compare September 24, 2019 21:16
@zubron zubron changed the title Try adding kind and dep to PATH in travis Add kind and dep to PATH in Travis Sep 25, 2019
@zubron zubron marked this pull request as ready for review September 25, 2019 11:34
@zubron zubron requested a review from johnSchnake September 25, 2019 11:55
@johnSchnake johnSchnake merged commit e30312b into vmware-tanzu:master Sep 25, 2019
@zubron zubron deleted the add-kind-to-path-in-travis branch September 27, 2019 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants