Merge pull request #208 from kaovilai/static-checks

static checks
vmware-tanzu · Oct 22, 2024 · cedace1 · cedace1
2 parents 882842b + 3d55db3
commit cedace1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/velero-plugin-for-aws/volume_snapshotter.go b/velero-plugin-for-aws/volume_snapshotter.go
@@ -242,7 +242,7 @@ func (b *VolumeSnapshotter) DeleteSnapshot(snapshotID string) error {
 	// see https://docs.aws.amazon.com/AWSEC2/latest/APIReference/errors-overview.html
 	var apiErr smithy.APIError
 	if errors.As(err, &apiErr) {
-		if "InvalidSnapshot.NotFound" == apiErr.ErrorCode() {
+		if apiErr.ErrorCode() == "InvalidSnapshot.NotFound" {
 			return nil
 		}
 	}

diff --git a/velero-plugin-for-aws/volume_snapshotter_test.go b/velero-plugin-for-aws/volume_snapshotter_test.go
@@ -132,7 +132,7 @@ func TestSetVolumeID(t *testing.T) {
 	}
 
 	// missing spec.awsElasticBlockStore -> error
-	updatedPV, err := b.SetVolumeID(pv, "vol-updated")
+	_, err := b.SetVolumeID(pv, "vol-updated")
 	require.Error(t, err)
 
 	// happy path
@@ -149,7 +149,7 @@ func TestSetVolumeID(t *testing.T) {
 		"labels": labels,
 	}
 
-	updatedPV, err = b.SetVolumeID(pv, "vol-updated")
+	updatedPV, err := b.SetVolumeID(pv, "vol-updated")
 
 	require.NoError(t, err)
 
@@ -167,7 +167,7 @@ func TestSetVolumeIDNoZone(t *testing.T) {
 	}
 
 	// missing spec.awsElasticBlockStore -> error
-	updatedPV, err := b.SetVolumeID(pv, "vol-updated")
+	_, err := b.SetVolumeID(pv, "vol-updated")
 	require.Error(t, err)
 
 	// happy path
@@ -176,7 +176,7 @@ func TestSetVolumeIDNoZone(t *testing.T) {
 		"awsElasticBlockStore": aws,
 	}
 
-	updatedPV, err = b.SetVolumeID(pv, "vol-updated")
+	updatedPV, err := b.SetVolumeID(pv, "vol-updated")
 
 	require.NoError(t, err)