switch per-backup/restore logs to use logrus #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecheney
approved these changes
Oct 6, 2017
pkg/backup/backup.go
Outdated
| @@ -133,13 +133,11 @@ func getNamespaceIncludesExcludes(backup *api.Backup) *collections.IncludesExclu | |||
| } | |||
|
|
|||
| type logger struct { | |||
There was a problem hiding this comment.
Does this provide much value? Why not just use the logrus logger directly?
There was a problem hiding this comment.
@davecheney no, was just taking the smallest possible step towards logrus here. Plan is to get rid of this intermediate layer.
pkg/restore/restore.go
Outdated
| // TODO use a real logger that supports writing to files | ||
| now := time.Now().Format(time.RFC3339) | ||
| fmt.Fprintf(l.w, now+" "+msg+"\n", args...) | ||
| l.impl.Infof(msg, args...) |
There was a problem hiding this comment.
same question as above; is there value in adding an abstraction above logrus?
|
SGTM. Make it so.
…On Fri, Oct 6, 2017 at 9:58 AM, Steve Kriss ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pkg/backup/backup.go
<#123 (comment)>:
> @@ -133,13 +133,11 @@ func getNamespaceIncludesExcludes(backup *api.Backup) *collections.IncludesExclu
}
type logger struct {
@davecheney <https://github.com/davecheney> no, was just taking the
smallest possible step towards logrus here. Plan is to get rid of this
intermediate layer.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#123 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAcA5EDXt_pro_RzBI1_kZAHb3dB7hYks5spZdqgaJpZM4Pv12x>
.
|
skriss
force-pushed
the
switch-backup-restore-log-impl
branch
from
f6f2789 to
d6bdaf3
Compare
skriss
changed the title
Signed-off-by: Steve Kriss <[email protected]>
skriss
force-pushed
the
switch-backup-restore-log-impl
branch
from
d6bdaf3 to
fa427eb
Compare
jmontleon
pushed a commit
to jmontleon/velero
that referenced
this pull request
Nov 9, 2021
Use numeric user for velero-restic-restore-helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #114
Fixes #115
(to be merged after #122)