-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable linter revive and resolve found errors: part2 #6177
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackpiglet
force-pushed
the
linter_revive_part2
branch
from
April 24, 2023 09:07
6fd6d81
to
4ab3c7c
Compare
blackpiglet
force-pushed
the
linter_revive_part2
branch
from
April 24, 2023 09:09
4ab3c7c
to
3c77fc1
Compare
blackpiglet
changed the title
Linter revive part2
Enable linter revive and resolve found errors: part2
Apr 24, 2023
Codecov Report
@@ Coverage Diff @@
## main #6177 +/- ##
==========================================
- Coverage 41.29% 41.27% -0.03%
==========================================
Files 251 251
Lines 23386 23377 -9
==========================================
- Hits 9658 9648 -10
- Misses 12970 12974 +4
+ Partials 758 755 -3
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Lyndon-Li
previously approved these changes
Apr 25, 2023
blackpiglet
force-pushed
the
linter_revive_part2
branch
from
April 25, 2023 08:34
3c77fc1
to
a22a345
Compare
33 tasks
Signed-off-by: Xun Jiang <[email protected]>
blackpiglet
force-pushed
the
linter_revive_part2
branch
from
April 25, 2023 15:02
a22a345
to
bb31de3
Compare
kaovilai
approved these changes
Apr 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Lyndon-Li
approved these changes
Apr 26, 2023
ywk253100
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.