-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump up kopia v0.13 #6248
Bump up kopia v0.13 #6248
Conversation
a4930c5
to
b497863
Compare
We face this problem of controller-gen after bumping up and changing go.mod, as a result, the |
b497863
to
76e2a8f
Compare
Codecov Report
@@ Coverage Diff @@
## main #6248 +/- ##
==========================================
- Coverage 41.19% 41.18% -0.01%
==========================================
Files 252 252
Lines 23418 23490 +72
==========================================
+ Hits 9647 9675 +28
- Misses 13015 13057 +42
- Partials 756 758 +2
|
76e2a8f
to
9fea274
Compare
@@ -68,6 +68,7 @@ type ObjectWriteOptions struct { | |||
Prefix ID // A prefix of the name used to save the object | |||
AccessMode int // OBJECT_DATA_ACCESS_* | |||
BackupMode int // OBJECT_DATA_BACKUP_* | |||
AsyncWrites int // Num of async writes for the object, 0 means no async write |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there is no place to assign value to the AsyncWrites
parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in (sr *shimRepository) NewObjectWriter
, it is an optional value, so right now, we don't need to set a value, just convey the value from shim to unified repo.
return object.ID{}, errors.New("ConcatenateObjects is not supported") | ||
} | ||
|
||
func (sr *shimRepository) OnSuccessfulFlush(callback repo.RepositoryWriterCallback) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious about why not OnSuccessfulFlush
function return value handling is different from other newly added functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The prototype of these functions are defined by Kopia, specifically, they implements Kopia' Repository interface. In the interface, OnSuccessfulFlush
has no return value.
On the other hand, this function is a callback under the Flush operation, while this callback is optional, if it is not to be handled, just leave it as empty.
Could you give more information on why the uber zap log library is used instead in |
Signed-off-by: Lyndon-Li <[email protected]>
9fea274
to
307b82a
Compare
|
Bump up kopia to v0.13
Fix issue #5999