-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retrieve DataUpload into result ConfigMap during volume snapshot restore. #6410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackpiglet
force-pushed
the
6117_fix
branch
6 times, most recently
from
June 21, 2023 08:43
aa50363
to
e199873
Compare
Lyndon-Li
reviewed
Jun 21, 2023
Codecov Report
@@ Coverage Diff @@
## main #6410 +/- ##
==========================================
+ Coverage 51.31% 53.86% +2.54%
==========================================
Files 228 229 +1
Lines 23777 23843 +66
==========================================
+ Hits 12202 12842 +640
+ Misses 10668 10051 -617
- Partials 907 950 +43
|
blackpiglet
changed the title
Retrieve DataUpload into backup result ConfigMap during volume snapshot restore.
Retrieve DataUpload into result ConfigMap during volume snapshot restore.
Jun 22, 2023
blackpiglet
force-pushed
the
6117_fix
branch
3 times, most recently
from
June 22, 2023 16:17
51e6397
to
79e7194
Compare
Lyndon-Li
previously approved these changes
Jun 23, 2023
Lyndon-Li
previously approved these changes
Jun 27, 2023
Lyndon-Li
previously approved these changes
Jun 28, 2023
@sseago |
shubham-pampattiwar
previously approved these changes
Jun 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One NIT, else LGTM! But I beleieve you need to rebase the PR due to conflicts.
…ot restore. Fix issue vmware-tanzu#6117. Add CSI plugin needs builder functions. Signed-off-by: Xun Jiang <[email protected]>
blackpiglet
dismissed stale reviews from shubham-pampattiwar and Lyndon-Li
via
June 30, 2023 03:13
ec4bb42
Signed-off-by: Xun Jiang/Bruce Jiang <[email protected]>
…ot restore. Fix issue vmware-tanzu#6117. Add CSI plugin needs builder functions. Signed-off-by: Xun Jiang <[email protected]>
Lyndon-Li
approved these changes
Jun 30, 2023
qiuming-best
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #6117.
Add CSI plugin needs builder functions.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fix issue #6117.
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.