Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hook filter display issue for backup describer #6434

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

allenxu404
Copy link
Contributor

@allenxu404 allenxu404 commented Jun 29, 2023

Thank you for contributing to Velero!

Please add a summary of your change

Backup describer displays hook filter specified in backup hook spec rather than backup spec

Does your change fix a particular issue?

Fixes #6043

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@allenxu404 allenxu404 changed the title fix hook filter display issue for backup describer Fix hook filter display issue for backup describer Jun 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2023

Codecov Report

Merging #6434 (75833ea) into main (de83980) will increase coverage by 1.24%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #6434      +/-   ##
==========================================
+ Coverage   58.41%   59.66%   +1.24%     
==========================================
  Files         227      227              
  Lines       23771    23771              
==========================================
+ Hits        13887    14182     +295     
+ Misses       8899     8603     -296     
- Partials      985      986       +1     
Impacted Files Coverage Δ
pkg/cmd/util/output/backup_describer.go 55.69% <100.00%> (ø)
pkg/cmd/util/output/backup_structured_describer.go 61.11% <100.00%> (ø)

... and 7 files with indirect coverage changes

@blackpiglet blackpiglet merged commit 5171ab0 into vmware-tanzu:main Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

velero backup crd hooks config includeNamesapces and includeResources,but describe did not show?
5 participants