-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move kopia logging from util/logging to remove indirect dependency in velero plugins #6484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaovilai
force-pushed
the
unkopia-for-plugins
branch
from
July 11, 2023 23:51
78929af
to
6809745
Compare
Codecov Report
@@ Coverage Diff @@
## main #6484 +/- ##
=======================================
Coverage 60.03% 60.03%
=======================================
Files 229 229
Lines 24491 24491
=======================================
Hits 14704 14704
Misses 8774 8774
Partials 1013 1013
|
kaovilai
changed the title
Moving kopia logging to remove kopia from indirect dependency in velero plugins
Moving kopia logging from util/logging to remove kopia from indirect dependency in velero plugins
Jul 12, 2023
Lyndon-Li
reviewed
Jul 12, 2023
3 tasks
…ro plugins when running `go mod why -m github.com/kopia/kopia` in velero-plugins prior to this change you will see following ``` ❯ go mod why -m github.com/kopia/kopia github.com/konveyor/openshift-velero-plugin/velero-plugins github.com/vmware-tanzu/velero/pkg/plugin/framework github.com/vmware-tanzu/velero/pkg/util/logging github.com/kopia/kopia/repo/logging ``` after ``` ❯ go mod why -m github.com/kopia/kopia (main module does not need module github.com/kopia/kopia) ``` Signed-off-by: Tiger Kaovilai <[email protected]>
kaovilai
force-pushed
the
unkopia-for-plugins
branch
from
July 12, 2023 14:44
6809745
to
0572287
Compare
kaovilai
changed the title
Moving kopia logging from util/logging to remove kopia from indirect dependency in velero plugins
Move kopia logging from util/logging to remove indirect dependency in velero plugins
Jul 12, 2023
seeing if I can restart linter check via reopening |
sseago
approved these changes
Jul 12, 2023
@Lyndon-Li Please take another look, Thanks ! |
Lyndon-Li
approved these changes
Jul 13, 2023
danfengliu
pushed a commit
to danfengliu/velero
that referenced
this pull request
Jul 13, 2023
Move kopia logging from util/logging to remove indirect dependency in velero plugins
danfengliu
pushed a commit
to danfengliu/velero
that referenced
this pull request
Jul 13, 2023
Move kopia logging from util/logging to remove indirect dependency in velero plugins
danfengliu
pushed a commit
to danfengliu/velero
that referenced
this pull request
Jul 13, 2023
Move kopia logging from util/logging to remove indirect dependency in velero plugins
danfengliu
pushed a commit
to danfengliu/velero
that referenced
this pull request
Jul 13, 2023
Move kopia logging from util/logging to remove indirect dependency in velero plugins
danfengliu
pushed a commit
to danfengliu/velero
that referenced
this pull request
Jul 14, 2023
Move kopia logging from util/logging to remove indirect dependency in velero plugins
danfengliu
pushed a commit
to danfengliu/velero
that referenced
this pull request
Jul 14, 2023
Move kopia logging from util/logging to remove indirect dependency in velero plugins
danfengliu
pushed a commit
to danfengliu/velero
that referenced
this pull request
Jul 14, 2023
Move kopia logging from util/logging to remove indirect dependency in velero plugins
danfengliu
pushed a commit
to danfengliu/velero
that referenced
this pull request
Jul 18, 2023
Move kopia logging from util/logging to remove indirect dependency in velero plugins
danfengliu
pushed a commit
to danfengliu/velero
that referenced
this pull request
Jul 18, 2023
Move kopia logging from util/logging to remove indirect dependency in velero plugins
3 tasks
danfengliu
pushed a commit
to danfengliu/velero
that referenced
this pull request
Jul 20, 2023
Move kopia logging from util/logging to remove indirect dependency in velero plugins
This was referenced Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when running
go mod why -m github.com/kopia/kopia
in velero-plugins prior to this change you will see followingafter
Signed-off-by: Tiger Kaovilai [email protected]
Thank you for contributing to Velero!
Please add a summary of your change
Velero Plugins no longer need kopia indirect dependency in their go.mod
Motivation for change
github.com/Azure/azure-sdk-for-go/sdk/storage/azblob v1.0.0
into our go.mod, this import breaks velero's import of kopia v0.13.0 which depends onazblob v0.3.0
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.