fix: load AWS config and assume role #6598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisdavim
force-pushed
the
fix_aws_creds
branch
from
cf46753 to
6a3b81e
Compare
luisdavim
force-pushed
the
fix_aws_creds
branch
from
6a3b81e to
56c11b3
Compare
luisdavim
force-pushed
the
fix_aws_creds
branch
from
56c11b3 to
7a77b9c
Compare
luisdavim
force-pushed
the
fix_aws_creds
branch
2 times, most recently
from
c6e5daa to
a272382
Compare
luisdavim
force-pushed
the
fix_aws_creds
branch
9 times, most recently
from
79ab15a to
d69852f
Compare
luisdavim
force-pushed
the
fix_aws_creds
branch
5 times, most recently
from
8e9c778 to
58643e6
Compare
Lyndon-Li
reviewed
Aug 9, 2023
Signed-off-by: Luis Davim <[email protected]>
luisdavim
force-pushed
the
fix_aws_creds
branch
from
58643e6 to
28c5dc9
Compare
Lyndon-Li
approved these changes
Aug 9, 2023
reasonerjt
approved these changes
Aug 10, 2023
This was referenced Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Currently
GetS3Credentialsis just getting the credentials from the config file directly but if we let the AWS SDK do it it will support things like assuming roles and source profiles.Does your change fix a particular issue?
Fixes #3142 for volumes where the fix for resource backups is in vmware-tanzu/velero-plugin-for-aws#168
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.