Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update restore controller logic for restore deletion #6761

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Update restore controller logic for restore deletion #6761

merged 1 commit into from
Sep 6, 2023

Conversation

ywk253100
Copy link
Contributor

  1. Skip deleting the restore files from storage if the backup/BSL is not found
  2. Allow deleting the restore files from storage even though the BSL is readonly

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@github-actions github-actions bot requested review from Lyndon-Li and sseago September 5, 2023 07:18
@ywk253100
Update restore controller logic for restore deletion
e4c9594 
1. Skip deleting the restore files from storage if the backup/BSL is not found
2. Allow deleting the restore files from storage even though the BSL is readonly

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
@codecov
Copy link

codecov bot commented Sep 5, 2023 •
edited
Loading

Codecov Report

Merging #6761 (e4c9594) into release-1.12 (6790a18) will not change coverage.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##           release-1.12    #6761   +/-   ##
=============================================
  Coverage         60.38%   60.38%           
=============================================
  Files               242      242           
  Lines             25981    25981           
=============================================
  Hits              15689    15689           
- Misses             9189     9190    +1     
+ Partials           1103     1102    -1
Files Changed Coverage Δ
pkg/controller/restore_controller.go 65.96% <0.00%> (ø)

@allenxu404
Copy link
Contributor

LGTM

@ywk253100 ywk253100 merged commit fc653bd into vmware-tanzu:release-1.12 Sep 6, 2023
sseago pushed a commit to openshift/velero that referenced this pull request May 23, 2024
@ywk253100 @sseago
Update restore controller logic for restore deletion (vmware-tanzu#6761)
841fc8c 
1. Skip deleting the restore files from storage if the backup/BSL is not found
2. Allow deleting the restore files from storage even though the BSL is readonly

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
kaovilai pushed a commit to kaovilai/velero that referenced this pull request Jun 18, 2024
@ywk253100 @kaovilai
Update restore controller logic for restore deletion (vmware-tanzu#6761)
7f7db26 
1. Skip deleting the restore files from storage if the backup/BSL is not found
2. Allow deleting the restore files from storage even though the BSL is readonly

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
@kaovilai kaovilai mentioned this pull request Jun 18, 2024
Closed
3 tasks
sseago pushed a commit to sseago/velero that referenced this pull request Jun 18, 2024
@ywk253100 @sseago
Update restore controller logic for restore deletion (vmware-tanzu#6761)
d2758ec 
1. Skip deleting the restore files from storage if the backup/BSL is not found
2. Allow deleting the restore files from storage even though the BSL is readonly

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
sseago pushed a commit to sseago/velero that referenced this pull request Jun 18, 2024
@ywk253100 @sseago
Update restore controller logic for restore deletion (vmware-tanzu#6761)
5b26e2c 
1. Skip deleting the restore files from storage if the backup/BSL is not found
2. Allow deleting the restore files from storage even though the BSL is readonly

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
sseago pushed a commit to sseago/velero that referenced this pull request Jul 18, 2024
@ywk253100 @sseago
Update restore controller logic for restore deletion (vmware-tanzu#6761)
65b1bd6 
1. Skip deleting the restore files from storage if the backup/BSL is not found
2. Allow deleting the restore files from storage even though the BSL is readonly

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
sseago pushed a commit to sseago/velero that referenced this pull request Aug 1, 2024
@ywk253100 @sseago
Update restore controller logic for restore deletion (vmware-tanzu#6761)
008cf6f 
1. Skip deleting the restore files from storage if the backup/BSL is not found
2. Allow deleting the restore files from storage even though the BSL is readonly

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
sseago pushed a commit to sseago/velero that referenced this pull request Aug 22, 2024
@ywk253100 @sseago
Update restore controller logic for restore deletion (vmware-tanzu#6761)
029d9b9 
1. Skip deleting the restore files from storage if the backup/BSL is not found
2. Allow deleting the restore files from storage even though the BSL is readonly

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
shubham-pampattiwar pushed a commit to shubham-pampattiwar/velero that referenced this pull request Aug 22, 2024
@ywk253100 @shubham-pampattiwar
Update restore controller logic for restore deletion (vmware-tanzu#6761)
0844087 
1. Skip deleting the restore files from storage if the backup/BSL is not found
2. Allow deleting the restore files from storage even though the BSL is readonly

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
sseago pushed a commit to sseago/velero that referenced this pull request Sep 19, 2024
@ywk253100 @sseago
Update restore controller logic for restore deletion (vmware-tanzu#6761)
c15541f 
1. Skip deleting the restore files from storage if the backup/BSL is not found
2. Allow deleting the restore files from storage even though the BSL is readonly

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
sseago pushed a commit to sseago/velero that referenced this pull request Dec 11, 2024
@ywk253100 @sseago
Update restore controller logic for restore deletion (vmware-tanzu#6761)
ebb9518 
1. Skip deleting the restore files from storage if the backup/BSL is not found
2. Allow deleting the restore files from storage even though the BSL is readonly

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allenxu404 allenxu404 allenxu404 approved these changes

@Lyndon-Li Lyndon-Li Lyndon-Li approved these changes

@sseago sseago sseago approved these changes

@reasonerjt reasonerjt Awaiting requested review from reasonerjt

Assignees

@ywk253100 ywk253100

Labels
has-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ywk253100 @allenxu404 @sseago @Lyndon-Li