Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default value of the velero_backup_last_status metrics. #6838

Merged

Conversation

yanggangtony
Copy link
Contributor

Thank you for contributing to Velero!

Please add a summary of your change

As issue describe.
Fix the metrics backup_last_status not report right value when the schedule down unexpectation

Does your change fix a particular issue?

Fixes #6809

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@yanggangtony yanggangtony changed the title Fix the metrics backup_last_status not report right value when the sc… Change the default value of the velero_backup_last_status metrics. Sep 19, 2023
@yanggangtony yanggangtony force-pushed the fix-metrics-backup_last_status branch from 6073c89 to cda722c Compare September 19, 2023 07:25
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #6838 (cda722c) into main (63c6a48) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6838   +/-   ##
=======================================
  Coverage   60.78%   60.78%           
=======================================
  Files         245      245           
  Lines       26255    26255           
=======================================
  Hits        15960    15960           
  Misses       9164     9164           
  Partials     1131     1131           

@ywk253100 ywk253100 merged commit d3e5bb7 into vmware-tanzu:main Sep 20, 2023
24 checks passed
@yanggangtony yanggangtony deleted the fix-metrics-backup_last_status branch September 20, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

velero_backup_last_status indicates failed backup, while in reality the backup was successful
4 participants