Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 7068: add a finalizer to protect retained VSC #7095

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

Lyndon-Li
Copy link
Contributor

@Lyndon-Li Lyndon-Li commented Nov 14, 2023

Fix issue #7068, due to a behavior of CSI external snapshotter, manipulations of VS and VSC may not be handled in the same order inside external snapshotter as the API is called. So add a protection finalizer to ensure the order

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (e826b70) 61.22% compared to head (cb651d0) 61.23%.

Files Patch % Lines
pkg/util/csi/volume_snapshot.go 75.00% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7095      +/-   ##
==========================================
+ Coverage   61.22%   61.23%   +0.01%     
==========================================
  Files         257      257              
  Lines       27259    27272      +13     
==========================================
+ Hits        16688    16701      +13     
  Misses       9388     9388              
  Partials     1183     1183              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ywk253100 ywk253100 merged commit dde0647 into vmware-tanzu:main Nov 14, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants