Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 7068: add a finalizer to protect retained VSC #7114

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

Lyndon-Li
Copy link
Contributor

Fix issue #7068, due to a behavior of CSI external snapshotter, manipulations of VS and VSC may not be handled in the same order inside external snapshotter as the API is called. So add a protection finalizer to ensure the order

@Lyndon-Li Lyndon-Li marked this pull request as ready for review November 16, 2023 10:52
@github-actions github-actions bot requested review from sseago and ywk253100 November 16, 2023 10:53
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (a036e8d) 60.58% compared to head (25fc2f4) 60.61%.

Files Patch % Lines
pkg/util/csi/volume_snapshot.go 79.06% 6 Missing and 3 partials ⚠️
pkg/exposer/csi_snapshot.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.12    #7114      +/-   ##
================================================
+ Coverage         60.58%   60.61%   +0.03%     
================================================
  Files               247      247              
  Lines             26499    26527      +28     
================================================
+ Hits              16054    16079      +25     
- Misses             9319     9321       +2     
- Partials           1126     1127       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lyndon-Li Lyndon-Li merged commit 3325a0c into vmware-tanzu:release-1.12 Nov 17, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants