-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BackupRepositories associated with a BSL are invalidated when BSL is (re-)created. #7380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaovilai
force-pushed
the
restic-recreate-repo
branch
from
February 2, 2024 18:37
375b83b
to
1cc0f89
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7380 +/- ##
==========================================
- Coverage 61.65% 61.61% -0.04%
==========================================
Files 262 262
Lines 28479 28482 +3
==========================================
- Hits 17558 17550 -8
- Misses 9689 9699 +10
- Partials 1232 1233 +1 ☔ View full report in Codecov by Sentry. |
kaovilai
force-pushed
the
restic-recreate-repo
branch
4 times, most recently
from
February 5, 2024 22:20
044efef
to
fc68cb7
Compare
Simplify comments Signed-off-by: Tiger Kaovilai <[email protected]>
kaovilai
force-pushed
the
restic-recreate-repo
branch
from
February 5, 2024 22:21
fc68cb7
to
e9d1729
Compare
kaovilai
changed the title
Fix backupRepository (restic) can become stale after bsl recreate
BackupRepositories associated with a BSL are invalidated when BSL is (re-)created.
Feb 5, 2024
sseago
previously approved these changes
Feb 5, 2024
found a way to simplify.. |
Lyndon-Li
previously approved these changes
Feb 6, 2024
@kaovilai Please fix the CI problems. The current code looks good to me. |
Signed-off-by: Tiger Kaovilai <[email protected]>
kaovilai
force-pushed
the
restic-recreate-repo
branch
from
February 6, 2024 03:59
e02808f
to
423d63d
Compare
just need someone to rerun codecov upload |
Lyndon-Li
approved these changes
Feb 6, 2024
sseago
approved these changes
Feb 6, 2024
kaovilai
added a commit
to kaovilai/velero
that referenced
this pull request
Feb 6, 2024
…(re-)created. (vmware-tanzu#7380) * Add BackupRepositories invalidation on BSL Create Simplify comments Signed-off-by: Tiger Kaovilai <[email protected]> * Simplify Signed-off-by: Tiger Kaovilai <[email protected]> --------- Signed-off-by: Tiger Kaovilai <[email protected]>
kaovilai
added a commit
to kaovilai/velero
that referenced
this pull request
Feb 6, 2024
…(re-)created. (vmware-tanzu#7380) * Add BackupRepositories invalidation on BSL Create Simplify comments Signed-off-by: Tiger Kaovilai <[email protected]> * Simplify Signed-off-by: Tiger Kaovilai <[email protected]> --------- Signed-off-by: Tiger Kaovilai <[email protected]>
kaovilai
added a commit
to kaovilai/velero
that referenced
this pull request
Feb 6, 2024
…(re-)created. (vmware-tanzu#7380) * Add BackupRepositories invalidation on BSL Create Simplify comments Signed-off-by: Tiger Kaovilai <[email protected]> * Simplify Signed-off-by: Tiger Kaovilai <[email protected]> --------- Signed-off-by: Tiger Kaovilai <[email protected]>
kaovilai
added a commit
to kaovilai/velero
that referenced
this pull request
Feb 6, 2024
…(re-)created. (vmware-tanzu#7380) * Add BackupRepositories invalidation on BSL Create Simplify comments Signed-off-by: Tiger Kaovilai <[email protected]> * Simplify Signed-off-by: Tiger Kaovilai <[email protected]> --------- Signed-off-by: Tiger Kaovilai <[email protected]>
kaovilai
added a commit
to kaovilai/velero
that referenced
this pull request
Feb 6, 2024
…(re-)created. (vmware-tanzu#7380) * Add BackupRepositories invalidation on BSL Create Simplify comments Signed-off-by: Tiger Kaovilai <[email protected]> * Simplify Signed-off-by: Tiger Kaovilai <[email protected]> --------- Signed-off-by: Tiger Kaovilai <[email protected]>
Lyndon-Li
added a commit
that referenced
this pull request
Feb 20, 2024
release-1.12: BackupRepositories associated with a BSL are invalidated when BSL is (re-)created. (#7380)
Lyndon-Li
added a commit
that referenced
this pull request
Feb 20, 2024
release-1.13: BackupRepositories associated with a BSL are invalidated when BSL is (re-)created. (#7380)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #7292
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.