Add checkpoint in fs backup deletion #7621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danfengliu
added
the
kind/changelog-not-required
danfengliu
force-pushed
the
add-checkpoint-in-fs-backup-deletion
branch
from
2dde077 to
9bdb6cb
Compare
danfengliu
force-pushed
the
add-checkpoint-in-fs-backup-deletion
branch
from
9bdb6cb to
47f1017
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7621 +/- ##
=======================================
Coverage 58.65% 58.65%
=======================================
Files 344 344
Lines 28730 28730
=======================================
Hits 16853 16853
Misses 10448 10448
Partials 1429 1429 ☔ View full report in Codecov by Sentry. |
danfengliu
force-pushed
the
add-checkpoint-in-fs-backup-deletion
branch
4 times, most recently
from
d812135 to
2b3b719
Compare
danfengliu
force-pushed
the
add-checkpoint-in-fs-backup-deletion
branch
4 times, most recently
from
ba2e829 to
c735b36
Compare
danfengliu
force-pushed
the
add-checkpoint-in-fs-backup-deletion
branch
4 times, most recently
from
9d56564 to
7466eb7
Compare
danfengliu
force-pushed
the
add-checkpoint-in-fs-backup-deletion
branch
2 times, most recently
from
fffbb32 to
45c9999
Compare
As per PR vmware-tanzu#7281, if repository count is more than 1, then snapshots deletion is achieved with a fast way, then we should have more than 1 FS backup repository per backup. Signed-off-by: danfengl <[email protected]>
danfengliu
force-pushed
the
add-checkpoint-in-fs-backup-deletion
branch
from
45c9999 to
61c4d7b
Compare
blackpiglet
approved these changes
May 8, 2024
qiuming-best
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
As per PR #7281, if repository count is more than 1, then snapshots deletion is achieved with a fast way, then we should have more than 1 FS backup repository per backup.
Does your change fix a particular issue?
Fixes #7545
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.