-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix condition matching in resource modifier when there are multiple rules #7715
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7715 +/- ##
=======================================
Coverage 58.66% 58.67%
=======================================
Files 344 344
Lines 28731 28737 +6
=======================================
+ Hits 16854 16860 +6
Misses 10448 10448
Partials 1429 1429 ☔ View full report in Codecov by Sentry. |
@27149chen Could you rebase to fix the linter errors? |
PR LGTM - @27149chen can you please consider adding a unit test for the scenario you described in the issue to ensure we do not regress this in future and the behaviour is captured in the UTs atleast. |
gentle ping @27149chen |
ut added, apologies for the delay |
done |
@27149chen |
@blackpiglet , I have run go mod tidy, but with no help |
…ent. Fix condition matching in resource modifier when there are multiple rules Signed-off-by: lou <[email protected]>
306a93e
to
b0f96cd
Compare
@27149chen Please check out and sign off again to make the DCO check pass. |
@blackpiglet thanks, DCO looks right |
Please add a summary of your change
Fix condition matching in resource modifier when there are multiple rules
Does your change fix a particular issue?
Fixes #7714
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.