Add existingResourcePolicy restore CR validation to controller. #7757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaovilai
force-pushed
the
addExistingResourcePolicyRestoreCRValidation
branch
from
f9b0d68 to
7cf879f
Compare
kaovilai
force-pushed
the
addExistingResourcePolicyRestoreCRValidation
branch
2 times, most recently
from
857d280 to
8e1bcbf
Compare
sseago
previously approved these changes
Apr 29, 2024
anshulahuja98
previously approved these changes
May 1, 2024
|
@kaovilai CI is failing, can you pl check |
Signed-off-by: Tiger Kaovilai <[email protected]>
kaovilai
force-pushed
the
addExistingResourcePolicyRestoreCRValidation
branch
from
8e1bcbf to
e1bef5b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7757 +/- ##
==========================================
+ Coverage 58.64% 58.66% +0.01%
==========================================
Files 344 345 +1
Lines 28720 28733 +13
==========================================
+ Hits 16843 16856 +13
- Misses 10447 10448 +1
+ Partials 1430 1429 -1 ☔ View full report in Codecov by Sentry. |
|
Fixed |
sseago
previously approved these changes
May 1, 2024
anshulahuja98
previously approved these changes
May 2, 2024
blackpiglet
reviewed
May 6, 2024
kaovilai
force-pushed
the
addExistingResourcePolicyRestoreCRValidation
branch
from
1f2fa88 to
c304594
Compare
kaovilai
force-pushed
the
addExistingResourcePolicyRestoreCRValidation
branch
from
c304594 to
c42683e
Compare
|
labels PR fix #7776 |
Signed-off-by: Tiger Kaovilai <[email protected]>
kaovilai
force-pushed
the
addExistingResourcePolicyRestoreCRValidation
branch
from
c42683e to
3c937d4
Compare
blackpiglet
approved these changes
May 13, 2024
shubham-pampattiwar
approved these changes
May 13, 2024
This was referenced Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tiger Kaovilai [email protected]
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #7347
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.