Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: storage plugin processes leak. #8011

Closed
wants to merge 1 commit into from

Conversation

yuanqijing
Copy link

Thank you for contributing to Velero!

Please add a summary of your change

fix #7925

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@sseago
Copy link
Collaborator

sseago commented Jul 12, 2024

@yuanqijing We actually don't need to initialize a new plugin manager at all in FinalizeBackup -- we can pass in the one we already initialized in the backup finalizer controller. I'm testing an alternate fix that does that and will post it if it works.

@sseago
Copy link
Collaborator

sseago commented Jul 12, 2024

@yuanqijing I've submitted #8012 which passes in the already-initialized plugin manager from the finalizer controller, so we don't need to spawn a new plugin process for get/put volume info. I've tested this locally and it resolves the leak.

@sseago
Copy link
Collaborator

sseago commented Jul 15, 2024

I'm going to go ahead and close this PR since #8012 has been merged which also fixes it.

@sseago sseago closed this Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.14.0+: Memory leaks on backups jobs (CSI backups + cloud plugin)
2 participants