Fix v1.15.0 migration case error #8349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xun Jiang <[email protected]>
blackpiglet
added
kind/changelog-not-required
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.15 #8349 +/- ##
=============================================
Coverage 58.99% 58.99%
=============================================
Files 367 367
Lines 38847 38847
=============================================
Hits 22918 22918
Misses 14467 14467
Partials 1462 1462 ☔ View full report in Codecov by Sentry. |
sseago
previously approved these changes
Oct 25, 2024
Signed-off-by: Xun Jiang <[email protected]>
blackpiglet
force-pushed
the
fix_v1.15.0_migration_case_error
branch
from
c373244 to
6f79c54
Compare
kaovilai
approved these changes
Oct 25, 2024
Lyndon-Li
approved these changes
Oct 28, 2024
reasonerjt
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
This PR is used to fix the E2E migration E2E error after bumping to v1.15.
The error was introduced in v1.14, which added hard-code logic to add the CSI plugin for the migration case's Velero install CLI. That works because the Velero v1.14 migration E2E test covers the v1.13 to the v1.14 migration. v1.13 still needs to install the CSI plugin.
The CSI plugin was integrated into Velero in v1.14. Add adding the CSI plugin for Velero no older than v1.14 will cause the same plugin to register twice error, which causes the Velero server to exit.
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
Remove the hard-code logic.
Read the should used plugins and their version from the Velero E2E default value.
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.