-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enable use-any from revive #8624
base: main
Are you sure you want to change the base?
Conversation
cfd19b0
to
996461c
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
996461c
to
cbba3bd
Compare
/kind changelog-not-required |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8624 +/- ##
==========================================
+ Coverage 59.33% 59.35% +0.02%
==========================================
Files 370 370
Lines 39932 39932
==========================================
+ Hits 23692 23700 +8
+ Misses 14744 14737 -7
+ Partials 1496 1495 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
+1 that we should prefer any
to interface{}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thank you for contributing to Velero!
Please add a summary of your change
enable and fixes use-any rule from revive
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
make new-changelog
) or comment/kind changelog-not-required
on this PR.site/content/docs/main
.