Windows and Joins work when columns have alias #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make sure that columns in the DDlog output relation appear in the same order as in the original SQL create statement. Signed-off-by: Amy Tai <[email protected]>
mihaibudiu
suggested changes
Sep 22, 2021
| // created by this Visitor. | ||
| if (scOrigCol.getExpression().equals(sc.getExpression())) { | ||
| Expression repl = subst.rewrite(sc.getExpression(), null); | ||
| Expression repl1 = dropTable.rewrite(repl, null); |
There was a problem hiding this comment.
maybe we should rename the 'dropTable' variable as 'dropTableSpecRewriter' or something like that.
There was a problem hiding this comment.
How about dropTableExprRewriter?
Signed-off-by: Amy Tai <[email protected]>
mihaibudiu
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make sure that columns in the DDlog output relation appear in the same order as in the original SQL create statement.
Signed-off-by: Amy Tai [email protected]