Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vochain: refactor proof verification logic #1246

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Conversation

p4u
Copy link
Member

@p4u p4u commented Feb 7, 2024

Add a new interface that all proving systems must implement. Split the proving systems in different packages.
On zkProof validation, check for the missing inputs.

Add a new interface that all proving systems must implement.
Split the proving systems in different packages.
On zkProof validation, check for the missing inputs.

Signed-off-by: p4u <[email protected]>
@p4u p4u requested a review from lucasmenendez February 7, 2024 11:27
Copy link
Contributor

@lucasmenendez lucasmenendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

crypto/zk/circuit/inputs_test.go Show resolved Hide resolved
crypto/zk/prover/pubsignals.go Show resolved Hide resolved
vochain/transaction/proofs/zkproof/zkproof.go Show resolved Hide resolved
@p4u p4u merged commit 1fa5460 into main Feb 7, 2024
19 checks passed
@p4u p4u deleted the f/refactor_check_proof branch February 7, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants