New package: volta-0.7.1 #18756
New package: volta-0.7.1 #18756
Conversation
atk
force-pushed
the
feat-volta
branch
2 times, most recently
from
84ed616 to
bc8f8b2
Compare
|
@atk you are able to re-open the PR, you just need to force push to that branch. I'm pretty sure it can be done. |
|
Still an installation script. I still do not like this. |
|
I just had a chat with the volta developers. The scripts are no longer required, so both those and the install script can go. |
|
I've checked back, there is no musl support for volta - yet. However, since the demand is there for something like volta to be used inside containers (for which Alpine LInux is very popular), it might be supported in the future. See: volta-cli/volta#473 |
|
Removed the superfluous patch. |
|
@Vaelatern, the button says I cannot reopen the PR because I force-pushed while it was closed. |
|
I have answered every of your change requests. May I ask why you closed the PR, @Vaelatern? |
|
Look closer. |
|
I'm really sorry to waste your time, but what am I supposed to look at? You asked for musl support, which is not possible at the moment but will be added once it is. You asked me to remove the install script, which I did. You asked be to reopen the previous PR, which GitHub won't let me do. What have I missed? |
|
It was closed with a commit: 58f4d59. The PR has been merged manually, but github is not smart enough to notice it if it has been merged/rebased by hand if the hash changed. |
|
Ah, thanks. |
|
I merged it, with a few tweaks that did not require a roundtrip, I could just quickly do them myself. Welcome to the void! |
See #18446. Unfortunately, I was not able to reopen the PR due to the force push (my bad). The comments from this PR have been resolved.