Update ASCII.php

[arshidkv12]

https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

php 8.4 : Implicitly marking parameter $replace_single_chars_only as nullable is deprecated, the explicit nullable type must be used instead

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[gilbertoalbino]

Update seems reasonable for fixing PHP 8.4 requirements.

[hafezdivandari]

This syntax requires PHP 7.1+, some check failures are probably because the current build supports PHP 7.0+

[Diddyy]

@voku Is this good to go? :)

[voku]

Sorry, I've been in hospital with my daughter for a few weeks. Today is my first day back at work and I'll catch up tonight/next morning.

[Diddyy]

Sorry, I've been in hospital with my daughter for a few weeks. Today is my first day back at work and I'll catch up tonight/next morning.

No stress and no need to be sorry! Hope everything is all good :)

[MrMicky-FR]

This wasn't mentioned before, but it seems that the PHPDoc isn’t up-to-date as now $replace_single_chars_only has the same behavior with both null and false since it’s only used here:

portable-ascii/src/voku/helper/ASCII.php

Line 844 in fc540ed

if (!$replace_single_chars_only) {

(It was changed in this commit)

[SupianIDz]

hi @voku, when will this be merged? PHP 8.4 will be released soon.

[elijahcruz12]

hi @voku, when will this be merged? PHP 8.4 will be released soon.

It's supposed to be released this week (on the 21st). Hopefully we can get this merged within the next few days.

[mokhosh]

I guess we could just default to false instead of making the bool nullable?

[MrMicky-FR]

I guess we could just default to false instead of making the bool nullable?

It could also be a nice solution IMHO and it also keeps compatibility with PHP 7.1, but it would be a (minor?) breaking change for codes where this argument is explicitly passed as null (which seems pretty unlikely as it’s the last parameter and null is already the default value). But this kind of decision is definitely up to @voku :)

[crynobone]

I believe #105 is a better solution.

[voku]

fixed via #105