Add Laravel Prompts to command interface #19 #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baspa
requested changes
Jan 9, 2025
| $this->info('Please wait while we scan your web page...'); | ||
| $this->line(''); | ||
| $url = $this->argument('url') ?? text( | ||
| label: 'Pleaes enter the url', |
| class SeoScanUrl extends Command | ||
| { | ||
| public $signature = 'seo:scan-url {url} {--javascript}'; | ||
| public $signature = 'seo:scan-url {url?} {--javascript}'; |
There was a problem hiding this comment.
What if I don't want to enter a url and want to scan the whole website?
There was a problem hiding this comment.
Ah never mind I see it's the Scan URL command 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to enhance the functionality and user experience of the SEO scanning tool. The primary updates include the integration of the Laravel Prompts package, modifications to the
SeoScanUrlcommand to improve user interaction, and updates to theSeoclass to utilize the new progress functionality.Integration and functionality improvements:
composer.json: Addedlaravel/promptspackage to the dependencies.src/Commands/SeoScanUrl.php: Updated the command to use Laravel Prompts for user input and progress indication. This includes changing theurlargument to be optional and adding interactive prompts for the URL and JavaScript option.Class updates:
src/Seo.php: Replaced the SymfonyProgressBarwith Laravel PromptsProgressfor better progress tracking. [1] [2]