Final transfer fixes #72
Conversation
h-haaks
force-pushed
the
Allign-operatingsystem_support-with-augeasproviders_core
branch
from
8e64ef1 to
cdfa71b
Compare
|
@bastelfreak I tried to add rhel/centos 9 support but the acceptance tests failed so I decided to drop that. |
metadata.json
Outdated
| "dependencies": [ | ||
| { | ||
| "name": "puppet/augeasproviders_core", | ||
| "version_requirement": ">= 2.4.0 < 4.0.0" | ||
| "version_requirement": ">= 2.4.0 < 5.0.0" |
There was a problem hiding this comment.
I decided to bump this dependency so that removing EoL operating systems in core is covered.
|
Should there be a transfer notice in README.md? |
h-haaks
changed the title
h-haaks
force-pushed
the
Allign-operatingsystem_support-with-augeasproviders_core
branch
from
b21b6d9 to
aa89e1b
Compare
metadata.json
Outdated
| "dependencies": [ | ||
| { | ||
| "name": "puppet/augeasproviders_core", | ||
| "version_requirement": ">= 2.4.0 < 4.0.0" | ||
| "version_requirement": ">= 3.2.0 < 5.0.0" |
There was a problem hiding this comment.
3.2.0 is the first release of puppet/augeasproviders_core
as metioned in https://github.com/voxpupuli/puppet-augeasproviders_sysctl/pull/69/files#r1099799384
There was a problem hiding this comment.
Bump this to 3.2.1 so that the save/load bug workaround is covered?
h-haaks
force-pushed
the
Allign-operatingsystem_support-with-augeasproviders_core
branch
from
36a8dcb to
34304f1
Compare
metadata.json
Outdated
| @@ -43,37 +42,6 @@ | |||
| "7", | |||
| "8" | |||
| ] | |||
| }, | |||
| { | |||
| "operatingsystem": "OracleLinux", | |||
There was a problem hiding this comment.
please only purge the operating systems that are EoL. OracleLinux should be fine, I don't know about OpenSUSE 42. FreeBSD 12 and 13 are fine, Arch is fine, OpenBSD 7 is fine as well.
There was a problem hiding this comment.
But how could this module support OSes that are not supported by augeasproviders_core?
Cleanup README.md Adjust version_requirements for augeasproviders_core dependency Remove EoL operatingsystems
h-haaks
force-pushed
the
Allign-operatingsystem_support-with-augeasproviders_core
branch
from
34304f1 to
4eb9429
Compare
| @@ -54,22 +53,20 @@ | |||
| { | |||
| "operatingsystem": "OpenSUSE", | |||
| "operatingsystemrelease": [ | |||
| "42.2" | |||
| "15.4" | |||
There was a problem hiding this comment.
Pull Request (PR) description
Cleanup README.md
Adjust version_requirements for augeasproviders_core dependency
Remove EoL operatingsystems