Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kmod fact #44

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Add kmod fact #44

merged 1 commit into from
Dec 1, 2021

Conversation

jcpunk
Copy link
Contributor

@jcpunk jcpunk commented Mar 26, 2018

This is an initial stab at #33

raphink
raphink reviewed May 16, 2018
View reviewed changes
lib/facter/kmod.rb Outdated Show resolved Hide resolved
raphink
raphink requested changes May 16, 2018
View reviewed changes
lib/facter/kmod.rb Outdated Show resolved Hide resolved
lib/facter/kmod.rb Outdated Show resolved Hide resolved
lib/facter/kmod.rb Outdated Show resolved Hide resolved
lib/facter/kmod.rb Outdated Show resolved Hide resolved
lib/facter/kmod.rb Outdated Show resolved Hide resolved
@jcpunk
Copy link
Contributor Author

jcpunk commented May 16, 2018

in theory I've just fixed up the requested bits.

raphink
raphink reviewed May 17, 2018
View reviewed changes
lib/facter/kmod.rb Outdated Show resolved Hide resolved
@raphink
Copy link
Member

raphink commented May 22, 2018

I went ahead and tested this fact (I hadn't really before).

I made a few fixes (including some that cancel changes I'd requested which actually don't work) on https://github.com/raphink/puppet-kmod/tree/pull/44

@jcpunk
Copy link
Contributor Author

jcpunk commented May 22, 2018

Looks good to me, I've applied the changes and flattened the patch

@jcpunk
Copy link
Contributor Author

jcpunk commented Oct 4, 2018

Just checking back in.

baurmatt
baurmatt requested changes Oct 5, 2018
View reviewed changes
lib/facter/kmod.rb Outdated Show resolved Hide resolved
@jcpunk
Copy link
Contributor Author

jcpunk commented Oct 5, 2018

Good call ;)

@stale
Copy link

stale bot commented Apr 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 19, 2021
@jcpunk jcpunk requested a review from raphink April 19, 2021 16:50
@stale stale bot removed the wontfix label Apr 19, 2021
@jcpunk jcpunk requested a review from baurmatt November 30, 2021 16:56
@baurmatt baurmatt added the enhancement New feature or request label Dec 1, 2021
@baurmatt baurmatt merged commit c6ad054 into voxpupuli:master Dec 1, 2021
@jcpunk jcpunk deleted the kmod-facts branch December 1, 2021 14:21
@kajinamit kajinamit mentioned this pull request Feb 2, 2022
Closed
@kenyon kenyon mentioned this pull request Feb 2, 2022
Closed
@kenyon
Copy link
Member

kenyon commented Feb 3, 2022

This fact causes warnings on puppet runs on some systems (depending on what modules are loaded), such as these:

Warning: Facter: Permission denied @ rb_sysopen - /sys/module/md_mod/parameters/new_array
Warning: Facter: Operation not permitted @ io_fread - /sys/module/kdb/parameters/enable_nmi

Not sure if there's anything we can do about it. It does make puppet runs kind of scary-looking for people who don't know what causes these warnings, though.

@jcpunk
Copy link
Contributor Author

jcpunk commented Feb 3, 2022

Does #78 help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baurmatt baurmatt baurmatt approved these changes

@raphink raphink Awaiting requested review from raphink

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcpunk @raphink @kenyon @baurmatt