Fix file detection to gather kmod fact #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File.exists? can't be used with confine. It should be used in actual logics, otherwise fact gathering fails with the following error. error while resolving custom facts in .../lib/facter/kmod.rb: expected argument to be a String, Symbol, or Hash Fixes #74
Fixes the following lint errors detected by rubocop. lib/facter/kmod.rb:2:11: C: Style/HashSyntax: Use the new Ruby 1.9 hash syntax. (https://github.com/bbatsov/ruby-style-guide#hash-literals) confine :kernel => :linux ^^^^^^^^^^ lib/facter/kmod.rb:7:13: W: Lint/DeprecatedClassMethods: File.exists? is deprecated in favor of File.exist?. if File.exists?('/sys/module') ^^^^^^^ lib/facter/kmod.rb:9:9: C: Style/MultipleComparison: Avoid comparing a variable with multiple items in a conditional, use Array#include? instead. next if directory == '.' or directory == '..' ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ lib/facter/kmod.rb:9:34: C: Style/AndOr: Use || instead of or. (https://github.com/bbatsov/ruby-style-guide#no-and-or-or) next if directory == '.' or directory == '..' ^^ lib/facter/kmod.rb:19:15: C: Style/MultipleComparison: Avoid comparing a variable with multiple items in a conditional, use Array#include? instead. next if param == '.' or param == '..' ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ lib/facter/kmod.rb:19:36: C: Style/AndOr: Use || instead of or. (https://github.com/bbatsov/ruby-style-guide#no-and-or-or) next if param == '.' or param == '..' ^^ lib/facter/kmod.rb:30:15: C: Style/MultipleComparison: Avoid comparing a variable with multiple items in a conditional, use Array#include? instead. next if used == '.' or used == '..' ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ lib/facter/kmod.rb:30:35: C: Style/AndOr: Use || instead of or. (https://github.com/bbatsov/ruby-style-guide#no-and-or-or) next if used == '.' or used == '..' ^^
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
File.exists? can't be used with confine. It should be used in actual
logics, otherwise fact gathering fails with the following error.
This Pull Request (PR) fixes the following issues
Fixes #74