puppet-lint: fix current violations

manifests/certificate/x509.pp

@@ -87,7 +87,7 @@
 #
 #   - `puppetlabs/stdlib`
 #
-define openssl::certificate::x509(
+define openssl::certificate::x509 (
   String                             $country,
   String                             $organization,
   String                             $commonname,
@@ -118,8 +118,7 @@
   Boolean                            $force = true,
   String                             $cnf_tpl = 'openssl/cert.cnf.erb',
   Boolean                            $encrypted = true,
-  ) {
-
+) {
   $_key_owner = pick($key_owner, $owner)
   $_key_group = pick($key_group, $group)
   $_cnf_dir = pick($cnf_dir, $base_dir)

manifests/certificates.pp

@@ -20,8 +20,7 @@
 #
 class openssl::certificates (
   Hash $x509_certs = {},
-){
-
+) {
   if $x509_certs {
     ensure_resources('openssl::certificate::x509', $x509_certs)
   }

manifests/configs.pp

@@ -67,8 +67,7 @@
   Optional[Array]   $keyusages         = undef,
   Optional[Array]   $subjectaltnames   = undef,
   Hash              $conffiles         = {},
-){
-
+) {
   # dpendencies: ensure config file is generated before potential usage
   File<| tag=='openssl-configs' |> -> Ssl_pkey<| |>
   File<| tag=='openssl-configs' |> -> X509_cert<| |>
@@ -80,22 +79,23 @@
       owner   => pick($vals['owner'], $owner),
       group   => pick($vals['group'], $group),
       mode    => pick($vals['mode'], $mode),
-      content => epp('openssl/cert.cnf.epp', {
-        country           => $country,
-        state             => $state,
-        locality          => $locality,
-        organization      => $organization,
-        unit              => $unit,
-        email             => $email,
-        default_bits      => $default_bits,
-        default_md        => $default_md,
-        default_keyfile   => $default_keyfile,
-        basicconstraints  => $basicconstraints,
-        extendedkeyusages => $extendedkeyusages,
-        keyusages         => $keyusages,
-        subjectaltnames   => $subjectaltnames,
-      } + delete($vals,['ensure', 'owner', 'group', 'mode']),
-    ),
+      content => epp('openssl/cert.cnf.epp',
+        {
+          country           => $country,
+          state             => $state,
+          locality          => $locality,
+          organization      => $organization,
+          unit              => $unit,
+          email             => $email,
+          default_bits      => $default_bits,
+          default_md        => $default_md,
+          default_keyfile   => $default_keyfile,
+          basicconstraints  => $basicconstraints,
+          extendedkeyusages => $extendedkeyusages,
+          keyusages         => $keyusages,
+          subjectaltnames   => $subjectaltnames,
+        } + delete($vals,['ensure', 'owner', 'group', 'mode']),
+      ),
       tag     => 'openssl-configs',
     }
   }

manifests/dhparam.pp

@@ -14,7 +14,7 @@
 #
 #   - `puppetlabs/stdlib`
 #
-define openssl::dhparam(
+define openssl::dhparam (
   Stdlib::Absolutepath      $path = $name,
   Enum['present', 'absent'] $ensure = present,
   Integer[1]                $size = 2048,
@@ -23,7 +23,6 @@
   String                    $mode = '0644',
   Boolean                   $fastmode = false,
 ) {
-
   dhparam { $path:
     ensure   => $ensure,
     size     => $size,
@@ -32,10 +31,10 @@
 
   # Set file access
   file { $path:
-      ensure  => $ensure,
-      owner   => $owner,
-      group   => $group,
-      mode    => $mode,
-      require => Dhparam[$path];
+    ensure  => $ensure,
+    owner   => $owner,
+    group   => $group,
+    mode    => $mode,
+    require => Dhparam[$path];
   }
 }

manifests/export/pem_cert.pp

@@ -19,7 +19,7 @@
   #local variables
 
   # If ensure = present and  der_cert and $pfx_cert as being specified, then throw error
-    if $ensure == present and !$der_cert and !$pfx_cert {
+  if $ensure == present and !$der_cert and !$pfx_cert {
     fail('Parameter Error: either pfx_cert or der_cert must be specified')
   }
 
@@ -53,7 +53,7 @@
 
     exec { "Export ${in_cert} to ${pem_cert}":
       command => inline_template('<%= @cmd.join(" ") %>'),
-      path    => $::path,
+      path    => $facts['path'],
       creates => $pem_cert,
     }
   } else {

manifests/export/pem_key.pp

@@ -37,7 +37,7 @@
 
     exec { "Export ${pfx_cert} to ${pem_key}":
       command => inline_template('<%= @cmd.join(" ") %>'),
-      path    => $::path,
+      path    => $facts['path'],
       creates => $pem_key,
     }
   } else {

manifests/export/pkcs12.pp

@@ -10,7 +10,7 @@
 #   [*out_pass*]  - PKCS12 password
 #   [*chaincert*] - chain certificate to include in pkcs12
 #
-define openssl::export::pkcs12(
+define openssl::export::pkcs12 (
   Stdlib::Absolutepath      $basedir,
   Stdlib::Absolutepath      $pkey,
   Stdlib::Absolutepath      $cert,
@@ -47,9 +47,9 @@
       $passout_opt,
     ]
 
-    exec {"Export ${name} to ${basedir}/${name}.p12":
+    exec { "Export ${name} to ${basedir}/${name}.p12":
       command => inline_template('<%= @cmd.join(" ") %>'),
-      path    => $::path,
+      path    => $facts['path'],
       creates => "${basedir}/${name}.p12",
     }
   } else {

manifests/packages.pp

@@ -12,9 +12,7 @@
   }
 
   if $facts['os']['family'] in ['Debian', 'RedHat'] {
-    ensure_packages(['ca-certificates'], {
-      ensure => $openssl::ca_certificates_ensure,
-    })
+    ensure_packages(['ca-certificates'], { ensure => $openssl::ca_certificates_ensure, })
 
     if $facts['os']['family'] == 'Debian' {
       exec { 'update-ca-certificates':