-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refreshable exports #202
feat: refreshable exports #202
Conversation
Add possibility to switch the underlying Execs to "refreshonly" mode and handle over subscriptions to resource(s) as parameter. This fixes also a bug when p12 file is not renewed after the input file changed. Backward compatibility fully given.
Missed unit tests, my bad, will update in the next days 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few improvements to the docs.
Co-authored-by: Kenyon Ralph <[email protected]>
d0388eb
to
4feddcc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a big user of this module, so I'm not sure how this feature would be used, but the code looks fine to me.
It's a big issue in a project I'm currently working on: if the certificate/key pair changes, the p12 and decrypted key files are not updated. In our case, the input files are also defined as a file resource and puppet is aware of any changes on these files. The contents of certificate and key files is pulled from a DB. If there is an update - the file resources take care of it, but the downstream logic in this OpenSSL Module won't do anything because of static "creates" parameter. Before creating this PR I've wrote some code for our private workaround - just added an Exec for deleting the p12 and key file in case the input files change. I suppose some other boys and girls out there did the same to fix the issue locally. But IMHO it's always a better way to implement a generic solution for everyone. Hope it matches the community expectations :) |
Pull Request (PR) description
Add possibility to switch the underlying Execs to "refreshonly" mode and hand over subscriptions to resource(s) as parameter. This fixes also a bug when p12 file is not renewed after the input file changed. Backward compatibility fully given.
This Pull Request (PR) fixes the following issues
Fixes #131