config.pp creates tmp as file but selinux_build_module_simple.sh wants to create a dir

[ericcolruyt]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 4.7.1
• Ruby: 2.1.9p490
• Distribution: RHEL7.3
• Module version: 1.0.0

How to reproduce (e.g Puppet code you use)

selinux::module {"ovcd_hostname":
  ensure    => present,
  source_te => "puppet:///modules/ito_systlinux_colruyt/usr/share/selinux/targeted/ovcd_hostname.te",
}

What are you seeing

...
Info: /Stage[main]/Ito_systlinux_colruyt::Setup/Zz_selinux_systlinux_colruyt::Module[ovcd_hostname]/Selinux::Module[ovcd_hostname]/Exec[clean-module-ovcd_hostname]: Scheduling refresh of Exec[build-module-ovcd_hostname]
Notice: /Stage[main]/Ito_systlinux_colruyt::Setup/Zz_selinux_systlinux_colruyt::Module[ovcd_hostname]/Selinux::Module[ovcd_hostname]/Exec[build-module-ovcd_hostname]/returns: mkdir: cannot create directory ‘tmp’: File exists
Error: /opt/puppetlabs/puppet/cache/puppet-selinux/bin/selinux_build_module_simple.sh ovcd_hostname /opt/puppetlabs/puppet/cache/puppet-selinux/modules || (rm -f /opt/puppetlabs/puppet/cache/puppet-selinux/modules/ovcd_hostname.pp /opt/puppetlabs/puppet/cache/puppet-selinux/modules/ovcd_hostname.loaded && exit 1) returned 1 instead of one of [0]
Error: /Stage[main]/Ito_systlinux_colruyt::Setup/Zz_selinux_systlinux_colruyt::Module[ovcd_hostname]/Selinux::Module[ovcd_hostname]/Exec[build-module-ovcd_hostname]/returns: change from notrun to 0 failed: /opt/puppetlabs/puppet/cache/puppet-selinux/bin/selinux_build_module_simple.sh ovcd_hostname /opt/puppetlabs/puppet/cache/puppet-selinux/modules || (rm -f /opt/puppetlabs/puppet/cache/puppet-selinux/modules/ovcd_hostname.pp /opt/puppetlabs/puppet/cache/puppet-selinux/modules/ovcd_hostname.loaded && exit 1) returned 1 instead of one of [0]
Notice: /Stage[main]/Ito_systlinux_colruyt::Setup/Zz_selinux_systlinux_colruyt::Module[ovcd_hostname]/Selinux::Module[ovcd_hostname]/Exec[build-module-ovcd_hostname]/returns: mkdir: cannot create directory ‘tmp’: File exists
Error: /Stage[main]/Ito_systlinux_colruyt::Setup/Zz_selinux_systlinux_colruyt::Module[ovcd_hostname]/Selinux::Module[ovcd_hostname]/Exec[build-module-ovcd_hostname]: Failed to call refresh: /opt/puppetlabs/puppet/cache/puppet-selinux/bin/selinux_build_module_simple.sh ovcd_hostname /opt/puppetlabs/puppet/cache/puppet-selinux/modules || (rm -f /opt/puppetlabs/puppet/cache/puppet-selinux/modules/ovcd_hostname.pp /opt/puppetlabs/puppet/cache/puppet-selinux/modules/ovcd_hostname.loaded && exit 1) returned 1 instead of one of [0]
Error: /Stage[main]/Ito_systlinux_colruyt::Setup/Zz_selinux_systlinux_colruyt::Module[ovcd_hostname]/Selinux::Module[ovcd_hostname]/Exec[build-module-ovcd_hostname]: /opt/puppetlabs/puppet/cache/puppet-selinux/bin/selinux_build_module_simple.sh ovcd_hostname /opt/puppetlabs/puppet/cache/puppet-selinux/modules || (rm -f /opt/puppetlabs/puppet/cache/puppet-selinux/modules/ovcd_hostname.pp /opt/puppetlabs/puppet/cache/puppet-selinux/modules/ovcd_hostname.loaded && exit 1) returned 1 instead of one of [0]
Notice: /Stage[main]/Ito_systlinux_colruyt::Setup/Zz_selinux_systlinux_colruyt::Module[ovcd_hostname]/Selinux::Module[ovcd_hostname]/Exec[install-module-ovcd_hostname]: Dependency Exec[build-module-ovcd_hostname] has failures: true
Warning: /Stage[main]/Ito_systlinux_colruyt::Setup/Zz_selinux_systlinux_colruyt::Module[ovcd_hostname]/Selinux::Module[ovcd_hostname]/Exec[install-module-ovcd_hostname]: Skipping because of failed dependencies
...

What behaviour did you expect instead

Info: /Stage[main]/Ito_systlinux_colruyt::Setup/Zz_selinux_systlinux_colruyt::Module[ovcd_hostname]/Selinux::Module[ovcd_hostname]/Exec[clean-module-ovcd_hostname]: Scheduling refresh of Exec[build-module-ovcd_hostname]
Notice: /Stage[main]/Ito_systlinux_colruyt::Setup/Zz_selinux_systlinux_colruyt::Module[ovcd_hostname]/Selinux::Module[ovcd_hostname]/Exec[build-module-ovcd_hostname]/returns: executed successfully
Info: /Stage[main]/Ito_systlinux_colruyt::Setup/Zz_selinux_systlinux_colruyt::Module[ovcd_hostname]/Selinux::Module[ovcd_hostname]/Exec[build-module-ovcd_hostname]: Scheduling refresh of Exec[install-module-ovcd_hostname]

Output log

See above

Any additional information you'd like to impart

After modifying the following in config.pp, things worked as expected:

  # created by refpolicy builder and our simple builder
  # ensure it does not get purged
  file {"${module_build_dir}/tmp":
    ensure => directory,
    selinux_ignore_defaults => true
  }

[oranenj]

The proposed fix seems fine to me, so I created a PR