Fix puppet strings warnings and minor README.md update #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Jan 31, 2017
README.md
Outdated
| * run acceptance tests: | ||
|
|
||
| ``` | ||
| BEAKER_debug=yes BEAKER_set="centos-6-x64" PUPPET_INSTALL_TYPE="agent" be rake beaker |
There was a problem hiding this comment.
not everybody uses this alias. should we use bundle exec instead?
|
added the centos 6 and 7 nodesets too. PR open in modulesync_config: voxpupuli/modulesync_config#313 |
Puppet 3.8.7 was specified in README.md but this is now Puppet 4 only.
|
don't merge. |
|
sorry, I thought the docs/ folder was messed up. but it was only my try to run |
EmRowlands
pushed a commit
to EmRowlands/puppet-selinux
that referenced
this pull request
Mar 29, 2023
Fix puppet strings warnings and minor README.md update
cegeka-jenkins
pushed a commit
to cegeka/puppet-selinux
that referenced
this pull request
Jan 10, 2025
Fix puppet strings warnings and minor README.md update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puppet 3.8.7 was specified in README.md but this is now Puppet 4 only.