Load system policy contexts #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
commented
Jun 14, 2019
| end | ||
|
|
||
| def self.prefetch(resources) | ||
| # is there a better way to do this? map port/protocol pairs to the provider regardless of the title |
There was a problem hiding this comment.
Not sure if this comment still makes sense.
ekohl
force-pushed
the
system-policy-contexts
branch
from
aea269f to
1cda42a
Compare
This change prefetches the system policy contexts. This means that if the system policy already exists for /var/spool/squid(/.*)? then it won't attempt to override it when the specification matches. It does still allow modifications if for some reason the base policy is incorrect. Purging of all local contexts is also still possible.
ekohl
force-pushed
the
system-policy-contexts
branch
from
1cda42a to
f7db44c
Compare
alexjfisher
approved these changes
Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prefetches the system policy contexts. This means that if the system policy already exists for
/var/spool/squid(/.*)?then it won't attempt to override it when the specification matches. It does still allow modifications if for some reason the base policy is incorrect. Purging of all local contexts is also still possible.Inspired by #289
Fixes #288