Add ping and steps configuration #173
Conversation
Database ping and steps were not configurable because they were hardcoded. Now it's a parameter.
mvernimmen
force-pushed
the
add_ping_and_step_configuration
branch
from
79982a1 to
e6735d4
Compare
| <% if @databasestep -%> | ||
| step = <%= @databasestep %> | ||
| <% else -%> | ||
| step = 300 | ||
| <% end -%> | ||
|
|
||
| <% if @databasepings -%> | ||
| pings = <%= @databasepings %> | ||
| <% else -%> | ||
| pings = 20 | ||
| <% end -%> |
There was a problem hiding this comment.
Aren't databasestep and databasepings always defined now?
|
yes, I consider it defensive programming. Currently the variable is always
defined, but things may change in the future.
If you so desire I can change the template to just paste the value. Please
let me know.
…On Thu, 1 Aug 2024 at 20:19, Kenyon Ralph ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In templates/database.erb
<#173 (comment)>
:
> +<% if @databasestep -%>
+step = <%= @databasestep %>
+<% else -%>
step = 300
+<% end -%>
+
+<% if @databasepings -%>
+pings = <%= @databasepings %>
+<% else -%>
pings = 20
+<% end -%>
Aren't databasestep and databasepings always defined now?
—
Reply to this email directly, view it on GitHub
<#173 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANXC4S4VGBBJNQDR4KX3SDZPJ34JAVCNFSM6AAAAABL2QG3SKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMJTGU2TOMZWGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
"This is the time. Don't let it slip"
|
|
We should have tests instead of doing that. If you can add a test for the default content of |
|
I can interpret that in multiple ways. I other words, it's not entirely clear to me how you would like to have it. In my opinion the tests you mentioned are there in the template. shall I remove the defaults I added in manifests/init.pp ? Please help me understand better what you would like to see changed. |
By "tests" I meant rspec tests added to https://github.com/voxpupuli/puppet-smokeping/blob/34cf1bf28ab29c57c77e5bcde3fe96abf4d5ba53/spec/classes/init_spec.rb |
|
I do not have the time/priority to learn how to write rspec tests to do this. Therefore I'm closing this PR. |
Database ping and steps can be changed
Pull Request (PR) description
This adds 2 parameters to configure database step and pings values.
This Pull Request (PR) fixes the following issues
n/a