Add support for Puppet Plans #96
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the `tasks` mode of the Puppet parser to syntax check plans in the `plans/` directory of a module. Fixes voxpupuli#95.
MikaelSmith
commented
Nov 1, 2018
| @@ -13,7 +13,11 @@ def filelist(paths) | |||
| end | |||
|
|
|||
| def filelist_manifests | |||
| filelist("**/*.pp") | |||
| filelist("**/*.pp").exclude('plans/**/*') | |||
There was a problem hiding this comment.
I went conservative on what we check for plans; this obviously won't work well in a control repo layout. However since we now have two things with the same extension that are parsed differently, the only way to identify them is with file path.
@hlindberg have a suggestion here? Should we just set Puppet[:tasks] = true for all manifests? Is there future work to make that possible?
There was a problem hiding this comment.
At this point differentiate by path is the best we can do. Not sure what you mean by always setting Puppet[:tasks] = true, obviously it should not be set for non plans / scripts...
slauger
added a commit
to slauger/puppet-syntax
that referenced
this pull request
Nov 9, 2018
|
Looks like the related issue was resolved. |
bastelfreak
pushed a commit
to slauger/puppet-syntax
that referenced
this pull request
Oct 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
tasksmode of the Puppet parser to syntax check plans in theplans/directory of a module. Fixes #95.