Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature (xml key): allow in first level for rpc #1219

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jglongaron
Copy link

  • allow xmlKey in first level for rpc

Problem

Using xmlKey ('$xml') in the first level of args

var soap = require('soap');
  var url = 'http://example.com/wsdl?wsdl';
  var args = {$xml: '<action>1</action>'};

  soap.createClient(url, {}, function(err, client) {
      client.MyFunction(args, function(err, result) {
          ...
      });
  });

Request includes "$xml" tag instead of unescaped text

...<soap:body><MyFunction><$xml>&lt;tns:action&gt;&lt;...&lt;tns:/action&gt;&lt;</$xml></MyFunction></soap:body>...

New Request

...<soap:body><MyFunction><action>1</action></MyFunction></soap:body>...

@smokhov
Copy link
Contributor

smokhov commented Jan 12, 2025

@w666 -- this is one also has tests and no merge conflicts; can re-run the check to see if the current ones pass

@w666 w666 force-pushed the feature/xml_key_in_first_level_for_rpc branch from d7db95e to caaabd0 Compare January 15, 2025 07:14
@w666
Copy link
Collaborator

w666 commented Jan 15, 2025

Interesting, I don't see that new test in the build output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants