This repository has been archived by the owner on Jun 2, 2022. It is now read-only.
chore: Fix Image SSR blink #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for basestore ready! 🔨 Explore the source changes: 820eb1b 🔍 Inspect the deploy log: https://app.netlify.com/sites/basestore/deploys/614fb90579d2cf6a0dad8af4 😎 Browse the preview: https://deploy-preview-48--basestore.netlify.app |
Gatsby Cloud Build Reportbasestore 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 2m PerformanceLighthouse report
|
Preview is readyThis pull request generated a Preview👀 Preview: https://preview-48--base.preview.vtex.app |
emersonlaurentino
approved these changes
Sep 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
I was trying to fix the wild blink of the SSRed product image on the pdp. However, while digging I've found this issue open on Gatsby and decided to add a todo in our code for us to remember to upgrade it once they fix this problem
How it works?
Sonarqube bot will warn us about it and eventually we will upgrade gatsby-plugin-image and this problem will be fixed