-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relucture de routing.md
#11
Conversation
Signed-off-by: Bruno Lesieur <[email protected]>
Signed-off-by: Bruno Lesieur <[email protected]>
Signed-off-by: Bruno Lesieur <[email protected]>
Signed-off-by: Bruno Lesieur <[email protected]>
Signed-off-by: Bruno Lesieur <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quelques erreurs
en/guide/routing.md
Outdated
@@ -17,7 +17,7 @@ pages/ | |||
--| index.vue | |||
``` | |||
|
|||
will automatically generate: | |||
génère automatiquement : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
générera
en/guide/routing.md
Outdated
|
||
To define a dynamic route with a param, you need to define a .vue file OR a directory **prefixed by an underscore**. | ||
Pour définir une route dynmaique à l'aide d'un paramètre, vous devez définir un fichier `.vue` OU un répertoire **préfixé par un souligner (`_`)**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dynmaique => dynamique
souligner => souligné
en/guide/routing.md
Outdated
@@ -57,7 +57,7 @@ pages/ | |||
--| index.vue | |||
``` | |||
|
|||
will automatically generate: | |||
génère automatiquement : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
générera
en/guide/routing.md
Outdated
@@ -86,38 +86,38 @@ router: { | |||
} | |||
``` | |||
|
|||
As you can see the route named `users-id` has the path `:id?` which makes it optional, if you want to make it required, create an `index.vue` file in the `users/_id` directory. | |||
Comme vous pouvez le voir, la route nommée `users-id` contient le chemin `:id?` ce qui le rend optionnel; si vous voulez le rendre obligatoire, créez un fichier `index.vue` dans le dossier `users/_id`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ce qui le rend optionnel;
pourquoi la virgule a été remplacé en point virgule ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bien vu ! Je vais le remplacer par un . Surement parceque en français deux idée différente font l'objet de deux phrase mais comme là il y avait une virgule !
en/guide/routing.md
Outdated
|
||
Nuxt.js lets you create nested route by using the children routes of vue-router. | ||
Nuxt.js vous permets de créer des routes imbriquées en utilisant les routes enfants de vue-router. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
permets => permet
en/guide/routing.md
Outdated
@@ -127,7 +127,7 @@ pages/ | |||
--| users.vue | |||
``` | |||
|
|||
will automatically generate: | |||
va automatiquement génèrer : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
générera automatiquement :
en/guide/routing.md
Outdated
@@ -170,7 +170,7 @@ pages/ | |||
--| index.vue | |||
``` | |||
|
|||
will automatically generate: | |||
va automatiquement génèrer : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
générera automatiquement :
en/guide/routing.md
Outdated
|
||
A middleware can be asynchronous, simply return a `Promise` or use the 2nd `callback` argument: | ||
Un middleware peut être asynchrone, retourner une `Promise` ou utiliser une fonction de rappel en seconde argument : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seconde => second
en/guide/routing.md
Outdated
|
||
```js | ||
export default function (context) { | ||
context.userAgent = context.isServer ? context.req.headers['user-agent'] : navigator.userAgent | ||
} | ||
``` | ||
|
||
The middleware will be executed in series in this order: | ||
Le middleware sont exécuté en série dans l'ordre suivant : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sont => sera
Signed-off-by: Bruno Lesieur <[email protected]>
C'est dans la boîte @forresst ! Si c'est bon pour toi ! |
en/guide/routing.md
Outdated
title: Routing | ||
description: Nuxt.js use the file-system to generate the routes of your web applications, it's as simple as PHP to create routes. | ||
title: Routage | ||
description: Nuxt.js utilise le système de fichiers pour générer les routes de votre applications web, c'est aussi simple qu'en PHP de créer des routes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"application" sans 's'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
J'ai également un peu de peine avec le "c'est aussi simple que" pour deux raisons:
- Ça peut être décourageant pour des gens qui débutent, surtout s’ils n'y arrivent pas et que la doc leur dit que c'est facile
- Pour ceux qui n'ont jamais fait de PHP, la comparaison est inutile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je suis plutôt d'accord avec toi. Tu peux faire cette remarque ici ? nuxt#235 ou p-e ouvrir une issue à ce sujet ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oui je vais faire la remarque ici et on modifiera en fonction de la discussion :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
en/guide/routing.md
Outdated
@@ -17,7 +17,7 @@ pages/ | |||
--| index.vue | |||
``` | |||
|
|||
will automatically generate: | |||
générera automatiquement : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
génèrera
en/guide/routing.md
Outdated
@@ -57,7 +57,7 @@ pages/ | |||
--| index.vue | |||
``` | |||
|
|||
will automatically generate: | |||
générera automatiquement : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
génèrera
en/guide/routing.md
Outdated
@@ -127,7 +127,7 @@ pages/ | |||
--| users.vue | |||
``` | |||
|
|||
will automatically generate: | |||
générera automatiquement : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
génèrera
en/guide/routing.md
Outdated
@@ -170,7 +170,7 @@ pages/ | |||
--| index.vue | |||
``` | |||
|
|||
will automatically generate: | |||
générera automatiquement : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
génèrera
en/guide/routing.md
Outdated
@@ -213,25 +213,25 @@ router: { | |||
|
|||
## Transitions | |||
|
|||
Nuxt.js uses the [<transition>](http://vuejs.org/v2/guide/transitions.html#Transitioning-Single-Elements-Components) component to let you create amazing transitions/animations between your routes. | |||
Nuxt.js utilise le composant [`<transition>`](http://vuejs.org/v2/guide/transitions.html#Transitioning-Single-Elements-Components) afin de vous permettre de créer des transitions / animations époustouflantes entre vos routes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je trouve qu'"époustouflant" est de trop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Que pense tu de « afin de vous permettre de créer de superbes transitions / animations entre vos routes. »
en/guide/routing.md
Outdated
@@ -256,35 +256,35 @@ We add a new class in our global css in `assets/main.css`: | |||
} | |||
``` | |||
|
|||
then, we use the transition property to define the class name to use for this page transition: | |||
puis, nous utilions la propriété transition pour définir le nom de la classe à utiliser pour cette transition de page : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"utilisons"; il manque le 's' au milieu du premier verbe
en/guide/routing.md
Outdated
@@ -297,7 +297,7 @@ export default function ({ route }) { | |||
} | |||
``` | |||
|
|||
Then, in your `nuxt.config.js`, layout or page, use the `middleware` key: | |||
Puis, dans `nuxt.config.js`, pour une mise en page ou une page, utilisez le mot clef `middleware` : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
En graphie rectifiée: "mot-clé"
Signed-off-by: Bruno Lesieur <[email protected]>
Merci pour tes retours @rspt ! C'est dans la boîte ! Reste juste ce point que nous traiterons dans une autre PR https://github.com/vuejs-fr/nuxt/pull/11/files/52bf57bc0b8769b29762f07577ad9f8fefd9bae2#r139283562 suivant le retour côté originale. |
Si c'est bon pour toi @forresst, on merge ! |
C'est parti !