Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: create EffectScope using a factory function #8844

Merged
merged 6 commits into from
Mar 15, 2024
Merged

test: create EffectScope using a factory function #8844

merged 6 commits into from
Mar 15, 2024

Conversation

Alfred-Skyblue
Copy link
Member

No description provided.

sxzz
sxzz reviewed Aug 15, 2023
View reviewed changes
Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can keep the changes of unit tests, but revert runtime code. Seems like we removed new keyword only and but a new import specifier.

@Alfred-Skyblue
Copy link
Member Author

I think we can keep the changes of unit tests, but revert runtime code. Seems like we removed new keyword only and but a new import specifier.

Hi, I have rolled back runtime-core.

@sxzz sxzz changed the title chore: create EffectScope using a factory function test: create EffectScope using a factory function Aug 15, 2023
@sxzz sxzz added the ready to merge The PR is ready to be merged. label Aug 15, 2023
@github-actions GitHub Actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 89.3 kB 34 kB 30.6 kB
vue.global.prod.js 146 kB 53.2 kB 47.6 kB

Usages

Name Size Gzip Brotli
createApp 49.7 kB 19.5 kB 17.8 kB
createSSRApp 53 kB 20.8 kB 19 kB
defineCustomElement 52 kB 20.2 kB 18.4 kB
overall 63.2 kB 24.4 kB 22.2 kB

@haoqunjiang haoqunjiang merged commit cde47bf into vuejs:main Mar 15, 2024
11 checks passed
@Alfred-Skyblue Alfred-Skyblue deleted the test-effectScope branch March 18, 2024 01:39
lynxlangya pushed a commit to lynxlangya/core that referenced this pull request May 30, 2024
@Alfred-Skyblue @lynxlangya
test: create EffectScope using a factory function (vuejs#8844)
a807519
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz approved these changes

@haoqunjiang haoqunjiang haoqunjiang approved these changes

Assignees
No one assigned
Labels
ready to merge The PR is ready to be merged.
Projects
Issue / PR Management
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alfred-Skyblue @haoqunjiang @sxzz