Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change exact prop to only match the path part by default #37

Closed
wants to merge 3 commits into from
Closed

Change exact prop to only match the path part by default #37

wants to merge 3 commits into from

Conversation

posva
Copy link
Member

@posva posva commented May 14, 2019 •
edited
Loading

Rendered

Do you rely on exact to match the query and hash? If so for what kind of links? How do you match only the path in those cases

@posva posva added breaking change This RFC contains breaking changes or deprecations of old API. router labels May 14, 2019
@posva posva changed the title Router/link exact prop Change exact prop to only match the path part by default May 14, 2019
@posva posva added the final comments This RFC is in final comments period label Feb 27, 2020
@posva
Copy link
Member Author

posva commented Feb 27, 2020

This RFC is now in final comments stage. An RFC in final comments stage means that:

The core team has reviewed the feedback and reached consensus about the general direction of the RFC and believe that this RFC is a worthwhile addition to the framework.
Final comments stage does not mean the RFC's design details are final - we may still tweak the details as we implement it and discover new technical insights or constraints. It may even be further adjusted based on user feedback after it lands in an alpha/beta release.
If no major objections with solid supporting arguments have been presented after a week, the RFC will be merged and become an active RFC.

@posva
Copy link
Member Author

posva commented Apr 14, 2020

This is closed in favour of #136

@posva posva closed this Apr 14, 2020
@posva posva removed the final comments This RFC is in final comments period label Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephaneRavet StephaneRavet StephaneRavet approved these changes

Assignees
No one assigned
Labels
breaking change This RFC contains breaking changes or deprecations of old API. router
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@posva @StephaneRavet